allow ctx.cancel to be returned in all procs#297
Merged
Conversation
jackyzha0
requested review from
masad-frost and
zhounathan
and removed request for
a team
masad-frost
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
we want to be able to cancel a procedure from within a handler (e.g. in the upload case, if the client unexpectedly disconnects, we probably want to just cancel instead of returning some bogus result)
What changed
union the cancel type into all procedure handlers, we don't need to change the client as the client already has cancel in the reader type
Versioning